fix[decimal]: add sum support for decimals to chunked and constant #5023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Codecov Report❌ Patch coverage is ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
joseph-isaacs
commented
Oct 22, 2025
| DType::Decimal( | ||
| DecimalDType::new(precision, decimal_dtype.scale()), | ||
| *nullability, | ||
| Nullable, |
Contributor
Author
There was a problem hiding this comment.
This was incorrect
AdamGS
approved these changes
Oct 22, 2025
Contributor
|
I think we should unify the behaviour - for decimal array sum we widen the type and use wrapping arithmetic but here we widen the type and use checked arithmetic. I think I convinced myself that with the widended type you will only hit the issue if you ever have an array bigger than 2^32 elements. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fuzzer found these.